httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <brian.p...@cnet.com>
Subject Re: [PATCH] Rotate logs based on file size...
Date Wed, 12 Jun 2002 19:04:16 GMT
Ian Holsman wrote:

>
>
> In order to be able to calculate the size of the log file you will need
> to either use atomics or another kind of locking mechanism when you
> update the filesize, as you will have multiple threads updating this
> value concurrently.
>
> so -1 for me, as I don't think it will work on multi-cpu machines
> (changes to a +1 if I'm on crack and this does work properly on
> multi-cpu machines) 


The patch changes rotatelogs (single-threaded), not mod_log_config...
It's getting the file size from the inode, so the kernel is taking
care of atomicity.

--Brian



Mime
View raw message