httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stas Bekman <>
Subject [PATCH include/http_log.h] APLOG_TOCLIENT.
Date Tue, 04 Jun 2002 18:28:29 GMT

I'm not sure whether ap_log_rerror() is the only user of APLOG_TOCLIENT. 
If so here is the patch that adds the whole story to the header file, so 
one doesn't need to dig in the .c files to find out how it works.

Moreover, I'm still not happy with this description, as ap_log_rerror() 
doesn't really send the message to the client, but only sets 
'error-notes' and it depends on the handler what it does about it. If I 
understand this correctly the note is misleading.

Index: include/http_log.h
RCS file: /home/cvspublic/httpd-2.0/include/http_log.h,v
retrieving revision 1.37
diff -u -r1.37 http_log.h
--- include/http_log.h	23 May 2002 12:19:09 -0000	1.37
+++ include/http_log.h	4 Jun 2002 18:23:01 -0000
@@ -109,6 +109,9 @@

  /* Use APLOG_TOCLIENT to cause ap_log_rerror() to send the message
   * to the client in addition to recording it to the error log.
+ * In addition the following conditions should be true:
+ * the error level is 'warning' or more severe,
+ * AND there aren't already error-notes associated with this request
  #define APLOG_TOCLIENT          (APLOG_LEVELMASK + 2)

Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker     mod_perl Guide --->

View raw message