httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@apache.org>
Subject Re: Conditional GET handling with filters.
Date Fri, 07 Jun 2002 00:01:28 GMT
On Thu, Jun 06, 2002 at 04:11:12PM -0700, Ryan Bloom wrote:
> If you delay calling ap_meets_conditions, then you are going to slow
> down the server.  Think about the easiest case, default_handler and
> mod_deflate.  The default_handler grabs a file from the disk and sends
> it to mod_deflate, which compresses the data.  Then, in
> ap_http_header_filter, we see that the data hasn't changed, so we send a
> Not-Modified-Since response.  Now, we have wasted time compressing the
> response that was never actually sent.

Yup, the deflate case is especially bad.  So, we need to make the
decision before the handlers run.

> There are only two options in my mind for fixing this correctly.  1)   A
> directive that essentially tells the server not to check for conditional
> GET requests in a given directory/file/location/whatever.  2)  A flag
> someplace that modules can set to notify the core that it should skip
> the check.

#1 is wrong because we're clearly violating the RFC on this.
#2 seems like r->no_local_copy is the right flag.

The problem seems to be where we can set this?  -- justin

P.S. rbb and I are in irc.openprojects.net #apr tossing around
some ideas about where we can stick this check.

Mime
View raw message