httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <>
Subject Re: Conditional GET handling with filters.
Date Thu, 06 Jun 2002 21:26:28 GMT
On Thu, Jun 06, 2002 at 05:15:33PM -0400, Cliff Woolley wrote:
> On Thu, 6 Jun 2002, Joshua Slive wrote:
> > I got myself into a bug that is way over my head:
> >
> > It seems that conditional GET (If-Modified-Since) is not working at all
> > correctly with output filters.  If someone wants to take a look, please
> > have at it.
> I just posted some responses on that PR.  Not sure about the ETag
> question, but all the rest seems like normal behavior to me.

I think the ap_meets_conditions() call should be moved to the
ap_http_header_filter().  If the request then fails the
conditions, then the header filter can just pass the appropriate
code down.  (If a module changes the content, it needs to remove
Last-Modified as mod_include does.)

If a module would still like to check the conditions before
processing, they could, but I think that may not be a good
idea because of output filters.

Note that PHP and mod_include could NEVER return 304.  -- justin

View raw message