httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: BUG: http_vhost.c:fix_hostname
Date Sun, 23 Jun 2002 07:18:27 GMT
On Sat, 2002-06-22 at 13:56, Perry Harrington wrote:
> There is a bug in fix_hostname.  The comment above function says that the hostname
> is lowercased, but it's not.
> 
> the line which reads:
> 
>         *dst++ = *src++;
...
> should read:
> 
>         *dst++ = tolower(*src++);

Thanks, I'll commit a change to convert to lowercase.  All the virtual
hosting code that uses r->hostname is case-insensitive, but IMHO it's
better to normalize the case early to avoid surprising anyone who later
tries to write, for example, a custom vhosting module based on a
case-sensitive hash table.

--Brian



Mime
View raw message