httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <bp...@pacbell.net>
Subject Re: [REPOST] [PATCH] Implement ap_init_filter_func
Date Mon, 17 Jun 2002 07:01:28 GMT
On Sun, 2002-06-16 at 23:30, Justin Erenkrantz wrote:

> Q: What is my solution?
> A: I believe what is required is a way for a module to insert
> arbitrary code that is executed before the handler is invoked
> only when the filter is active for this request.

The one thing I don't like about this design is that it
combines two disparate concepts into a single mechanism:
  1. Allow filters to identify whether they're going to alter
     the output in a way that would prevent a 304.
  2. Allow modules to run arbitrary code before their
     filters are run.

Certainly, the second of these capabilities should be optional,
but I don't think the first one should be optional.  I'd rather
require all filters to declare, at the time of registration,
whether or not they'll invalidate the if-modified-since checks.
With the API in your patch, a module author can supply a
callback function that doesn't actually set r->no_local_copy,
even though it might be essential for the module to do so.
Breaking 304s is a fundamental enough problem that I'd prefer
to require a "no_304" flag as a mandatory argument to
ap_register_*_filter().

However, this patch is an improvement over the current code,
so:  +0.5

--Brian



Mime
View raw message