httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: Discarding bodies multiple times
Date Sat, 01 Jun 2002 07:46:03 GMT
> From: Cliff Woolley [mailto:jwoolley@virginia.edu]
> 
> On Fri, 31 May 2002, Ryan Bloom wrote:
> 
> > A filter should NEVER call ap_die.  At the very worst, it should
create
> > an error bucket and send it down the stack.
> 
> What about ap_http_header_filter() at line 1460 of http_protocol.c?
> 
>     APR_BRIGADE_FOREACH(e, b) {
>         if (e->type == &ap_bucket_type_error) {
>             ap_bucket_error *eb = e->data;
> 
>             ap_die(eb->status, r);
>             return AP_FILTER_ERROR;
>         }
>     }
> 
> Is that an exception to that rule?  (I did a grep for ap_die and this
was
> the only case of it being used in a filter... but I knew about this
one
> when I sent my original message because I ran into this one just the
other
> day.)

Not so much an exception as proof.  :-)  That is the code that is
executed when a filter sends an error_bucket down the stack.  :-)

Ryan



Mime
View raw message