Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 73230 invoked by uid 500); 14 May 2002 02:10:21 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 73217 invoked from network); 14 May 2002 02:10:21 -0000 Errors-To: Message-Id: <5.1.0.14.2.20020513193537.029befc8@pop3.rowe-clan.net> X-Sender: wrowe%rowe-clan.net@pop3.rowe-clan.net X-Mailer: QUALCOMM Windows Eudora Version 5.1 Date: Mon, 13 May 2002 20:05:49 -0500 To: dev@httpd.apache.org From: "William A. Rowe, Jr." Subject: Re: cvs commit: httpd-2.0/modules/arch/win32 mod_isapi.c In-Reply-To: <20020513155741.G3635@lyra.org> References: <20020513212313.10162.qmail@icarus.apache.org> <20020513212313.10162.qmail@icarus.apache.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; format=flowed X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N Outch... thanks. Fortunately, that isn't the final file. I had finished the entire effort, so I was attempting to break the changes into components that could be followed, bit by bit. It took a full day to break this overhaul into manageable, modular changes, sorry I missed that. Fortunately, subsequent changes drop out those issues entirely, which is why the mistakes weren't on my radar as I incrementally built diffs of it all. Bill At 05:57 PM 5/13/2002, you wrote: >On Mon, May 13, 2002 at 09:23:13PM -0000, wrowe@apache.org wrote: > > wrowe 02/05/13 14:23:13 > > > > Modified: modules/arch/win32 mod_isapi.c > > Log: > > Part two; nearly inconsequential - Made the log message prefix ISAPI: > > (rather than ISAPI with no trailing colon) and normalized some > variables > > and static fn names to 'apache names' rather than MSisms. > >When you do a replace of names, I *highly* recommend checking them... :-) > > >... > > @@ -135,65 +148,65 @@ > > long val; > > > > if (((val = strtol(arg, (char **) &scan, 10)) <= 0) || *scan) > > - return "ISAPIReadAheadBuffer must be a legitimate value."; > > + return "ISAPIread_ahead_buflen must be a legitimate value."; > >Whoops! > > >... > > /* > > - * Command handler for the ISAPIReadAheadBuffer directive, which is > TAKE1 > > + * Command handler for the ISAPIread_ahead_buflen directive, which > is TAKE1 > >Dang... > > >... > > else { > > - return "ISAPILogNotSupported must be on or off"; > > + return "ISAPIlog_unsupported must be on or off"; > >blarg... > >etc. > >Cheers, >-g > >-- >Greg Stein, http://www.lyra.org/