Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Message-ID: <3CF74A27.8000907@algroup.co.uk>
Date: Fri, 31 May 2002 11:02:15 +0100
From: Ben Laurie <ben@algroup.co.uk>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
 rv:1.0rc3) Gecko/20020523
MIME-Version: 1.0
To: dev@httpd.apache.org
Cc: httpd-2.0-cvs@apache.org
Subject: Re: cvs commit: httpd-2.0/modules/test mod_bucketeer.c
References: <20020531074323.81596.qmail@icarus.apache.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

jwoolley@apache.org wrote:
> jwoolley    2002/05/31 00:43:22
> 
>   Modified:    modules/test mod_bucketeer.c
>   Log:
>   we should be copying over all metadata buckets we don't understand, not
>   just error buckets.
>   
>   Revision  Changes    Path
>   1.12      +5 -4      httpd-2.0/modules/test/mod_bucketeer.c
>   
>   Index: mod_bucketeer.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/test/mod_bucketeer.c,v
>   retrieving revision 1.11
>   retrieving revision 1.12
>   diff -u -d -u -r1.11 -r1.12
>   --- mod_bucketeer.c	30 May 2002 21:10:19 -0000	1.11
>   +++ mod_bucketeer.c	31 May 2002 07:43:22 -0000	1.12
>   @@ -141,10 +141,11 @@
>                continue;
>            }
>    
>   -        if (AP_BUCKET_IS_ERROR(e)) {     
>   -            apr_bucket *err_copy;
>   -            apr_bucket_copy(e, &err_copy);
>   -            APR_BRIGADE_INSERT_TAIL(ctx->bb, err_copy);
>   +        if (e->length == 0) {

Looks like magic to me - perhaps wrap it in AP_BUCKET_IS_METADATA()?

Cheers,

Ben.

-- 
http://www.apache-ssl.org/ben.html       http://www.thebunker.net/

"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff