Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Fri, 31 May 2002 16:40:10 -0700
From: Justin Erenkrantz <jerenkrantz@apache.org>
To: dev@httpd.apache.org
Subject: Discarding bodies multiple times
Message-ID: <20020531164010.Z19485@apache.org>
Mail-Followup-To: Justin Erenkrantz <jerenkrantz@apache.org>,
	dev@httpd.apache.org
References: <20020531142047.W19485@apache.org>
 <00a701c208e9$2f0c4290$5600000a@KOJ>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <00a701c208e9$2f0c4290$5600000a@KOJ>;
 from rbb@covalent.net on Fri, May 31, 2002 at 02:21:52PM -0700

On Fri, May 31, 2002 at 02:21:52PM -0700, Ryan Bloom wrote:
> Without this fix, the entire test suite fails, because the HTTP_IN
> filter is sending requests with 0 Content-Length to the
> CORE_INPUT_FILTER to read the body.  This means that every request times
> out after some timeout.  It has nothing to do with Jeff's problem,
> because EVERY test was taking forever.  I did run the test-suite, so if
> this breaks anything, there is no test for it.

Well, it's any request where ap_discard_request_body() is called
more than once.  In the case of apache/404.t, default_handler calls
ap_discard_request_body() and then ap_die() calls it too.

I'm not terribly sure if this sequence is valid.  Why is
default_handler discarding the body if it can't handle the
request?  Shouldn't we only discard the body right before we
send the response?  

Or, we could add an eos_gotten to request_rec to indiciate
that the input filters have received EOS so that
discard_request_body won't be re-entrant.  I dunno.  -- justin