Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 3387 invoked by uid 500); 26 May 2002 22:07:30 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 3365 invoked from network); 26 May 2002 22:07:30 -0000 Date: Sun, 26 May 2002 15:17:43 -0700 From: Brian Pane Subject: Re: suexec, userdir, and mod_cgid Re: suexec related patches for PR 7810, 7791, 8291, 9038 In-reply-to: <1022444338.4902.27.camel@localhost> To: dev@httpd.apache.org Message-id: <1022451463.14882.47.camel@localhost> MIME-version: 1.0 X-Mailer: Ximian Evolution 1.0.3 (1.0.3-4) Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: quoted-printable References: <20020526041748.A29148@prodigy.Redbrick.DCU.IE> <1022444338.4902.27.camel@localhost> X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sun, 2002-05-26 at 13:18, Brian Pane wrote: > On Sat, 2002-05-25 at 20:17, Colm MacC=E1rthaigh wrote: > > patch 1 (mod_cgid.c) fixes 7810/9039/mod_cgid, it just works. >=20 > Patch 1 didn't work when I tried it. The problem was that it depends > on mod_userdir's get_suexec_id_doer() to create a proper suexec > config based on the userdir. But mod_userdir's get_suexec_id_doer() > function never is invoked, because mod_suexec's get_suexec_id_doer() > is called first. >=20 > I modified mod_userdir to insert its suexec identity function in > front of mod_suexec's. The suexec+cgid+userdir combination now works > properly in my test environment, but I'd like a second opinion before > I commit. Actually, as Colm pointed out in PR 9083, the precedence of mod_userdir vs mod_suexec is a more general design issue, independent of mod_cgid. With patch1 and without a mod_userdir change, the combination of cgid+userdir+suexec works as long as there's no global SuexecUserGroup directive. That brings cgid up to par with cgi, so I'll commit the cgid patch. --Brian