httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brad Nicholes" <BNICHO...@novell.com>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c mod_rewrite.h
Date Mon, 06 May 2002 20:09:59 GMT
    That would work but it doesn't really seem like the right thing to
do.  APR.h already has some #defines for other situations such as
APR_USE_SYSVSEM_SERIALIZE.  Maybe if that #define doesn't make since,
another one should be added to platform versions of APR.h and then used
wherever SysV needs it.

Brad

Brad Nicholes
Senior Software Engineer
Novell, Inc., a leading provider of Net business solutions
http://www.novell.com 

>>> aaron@clove.org Monday, May 06, 2002 2:04:32 PM >>>
On Mon, May 06, 2002 at 01:49:36PM -0600, Brad Nicholes wrote:
>   Why are we calling a Unix specific function in the middle of a
module?
>  Since unixd_set_global_mutex_perms() doesn't exist on NetWare,
> mod_rewrite won't compile.  Should this be handled in APR somewhere?

For now, would this take care of it? I know this is a stupid thing
to have, but until we have a better permissions setup in APR this
seems like the only way to get it working. The same thing needs to
happen anywhere we use an inherited proc or global mutex in a module
(mod_ssl is the next target).

-aaron



Index: modules/mappers/mod_rewrite.c
===================================================================
RCS file: /home/cvs/httpd-2.0/modules/mappers/mod_rewrite.c,v
retrieving revision 1.111
diff -u -u -r1.111 mod_rewrite.c
--- modules/mappers/mod_rewrite.c	6 May 2002 18:24:03
-0000	1.111
+++ modules/mappers/mod_rewrite.c	6 May 2002 20:02:08 -0000
@@ -964,6 +964,7 @@
         return HTTP_INTERNAL_SERVER_ERROR;
     }
 
+#if !defined(OS2) && !defined(WIN32) && !defined(BEOS)  &&
!defined(NETWARE)
     rv = unixd_set_global_mutex_perms(rewrite_log_lock);
     if (rv != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_CRIT, rv, s,
@@ -971,6 +972,7 @@
                      "rewrite_log_lock; check User and Group
directives");
         return HTTP_INTERNAL_SERVER_ERROR;
     }
+#endif
 
     rv = rewritelock_create(s, p);
     if (rv != APR_SUCCESS) {
@@ -3327,6 +3329,7 @@
         return rc;
     }
 
+#if !defined(OS2) && !defined(WIN32) && !defined(BEOS)  &&
!defined(NETWARE)
     rc = unixd_set_global_mutex_perms(rewrite_mapr_lock_acquire);
     if (rc != APR_SUCCESS) {
         ap_log_error(APLOG_MARK, APLOG_CRIT, rc, s,
@@ -3334,6 +3337,7 @@
                      "on RewriteLock; check User and Group
directives");
         return rc;
     }
+#endif
 
     return APR_SUCCESS;
 }

Mime
View raw message