httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: httpd-2.0/modules/arch/win32 mod_isapi.c
Date Tue, 14 May 2002 01:05:49 GMT
Outch... thanks.

Fortunately, that isn't the final file.   I had finished the entire effort, 
so I was
attempting to break the changes into components that could be followed,
bit by bit.  It took a full day to break this overhaul into manageable, 
modular
changes, sorry I missed that.

Fortunately, subsequent changes drop out those issues entirely, which is
why the mistakes weren't on my radar as I incrementally built diffs of it all.

Bill

At 05:57 PM 5/13/2002, you wrote:
>On Mon, May 13, 2002 at 09:23:13PM -0000, wrowe@apache.org wrote:
> > wrowe       02/05/13 14:23:13
> >
> >   Modified:    modules/arch/win32 mod_isapi.c
> >   Log:
> >     Part two; nearly inconsequential - Made the log message prefix ISAPI:
> >     (rather than ISAPI with no trailing colon) and normalized some 
> variables
> >     and static fn names to 'apache names' rather than MSisms.
>
>When you do a replace of names, I *highly* recommend checking them... :-)
>
> >...
> >   @@ -135,65 +148,65 @@
> >        long val;
> >
> >        if (((val = strtol(arg, (char **) &scan, 10)) <= 0) || *scan)
> >   -        return "ISAPIReadAheadBuffer must be a legitimate value.";
> >   +        return "ISAPIread_ahead_buflen must be a legitimate value.";
>
>Whoops!
>
> >...
> >    /*
> >   - * Command handler for the ISAPIReadAheadBuffer directive, which is 
> TAKE1
> >   + * Command handler for the ISAPIread_ahead_buflen directive, which 
> is TAKE1
>
>Dang...
>
> >...
> >        else {
> >   -        return "ISAPILogNotSupported must be on or off";
> >   +        return "ISAPIlog_unsupported must be on or off";
>
>blarg...
>
>etc.
>
>Cheers,
>-g
>
>--
>Greg Stein, http://www.lyra.org/



Mime
View raw message