httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Martin Kraemer <Martin.Krae...@Fujitsu-Siemens.com>
Subject Re: [PATCH] Include Directives in apache 1.3
Date Wed, 29 May 2002 12:22:02 GMT
On Tue, May 28, 2002 at 06:36:28PM +0100, Colm MacCárthaigh wrote:
> But the contexts get warped when you call Include and certain
> things are allowed and certain not allowed because they are
> always treated as resource configs .. and so on

Yes, I stubled over that problem myself several times.

> The patch below should 
> fix it, I simply copied ap_process_resource_config and removed the lines 
> that warp the context, ap_process_include_config inherits the correct 
> context from it's caller.

The result would be much more what the user expects from an "Include"
directive.
+1 on concept (some more test driving needed to see whether it causes
any unwanted side effects?)

> Index: src/main/http_core.c
> ===================================================================
> +    bcopy(cmd, &parms, sizeof(parms));

Noooooo.... Bcopy is nonstandard. Use:
> +    memcpy(&parms, cmd, sizeof(parms));
instead. Does it maybe require a (void*) cast? (untested)

   Martin
-- 
<Martin.Kraemer@Fujitsu-Siemens.com>         |     Fujitsu Siemens
Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730  Munich,  Germany

Mime
View raw message