httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: [PATCH] prg: type RewriteMap can now take arguments again
Date Thu, 23 May 2002 18:53:54 GMT
> From: James Tait [mailto:JTait@wyrddreams.demon.co.uk]
> 
> See bugzilla id #8464 for details, but currently in 2.0.36 you cannot
> specify command-line arguments to an external rewrite program, thus:
> 
> RewriteMap "prg:/path/to/my/engine -arg1 -arg2"
> 
> This was valid in 1.3.24, as it exec'd a shell with the "-c
> /path/to/my/engine -arg1 -arg2" arguments.
> 
> Hopefully this patch should enable us to be able to supply
command-line
> arguments to our external program again, negating the need for a shell
> script wrapper and meaning the configuration is all in httpd.conf.

In general, this is good, but it duplicates some logic already in apr.
There is a function, tokenize_to_argv, which given a string, will pass
back an argv array.  If we use that, then we get the ability to quote
the arguments, and there is less duplicate code.  Please re-submit with
that change, and I will apply the patch.

Ryan



Mime
View raw message