> From: Justin Erenkrantz [mailto:jerenkrantz@apache.org]
>
> On Thu, May 30, 2002 at 02:43:05PM -0700, Ryan Bloom wrote:
> > This doesn't fix the underlying problem. Mod_bucketeer needs to be
> > smart enough to copy buckets if it doesn't recognize their type. If
the
> > bucket can't be copied, then the filter should remove the bucket
from
> > one brigade and add it to the other.
> >
> > Any filter that silently removes buckets is broken.
>
> True, but I thought part of the idea behind buckets is so that the
> backing type doesn't have to be known.
Exactly!
> The fact here is that not all buckets can be "read" such as EOS,
> flush, and error. Perhaps these buckets should return an error
> if they are read? Then, if a filter sees APR_ENOTIMPL, it can
> copy them over.
Every bucket can be read. That is a mandatory function that all buckets
must implement. If the back-end bucket-type isn't know, the filter can
ALWAYS do a read/apr_bucket_make_heap.
Ryan
|