httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: cvs commit: httpd-2.0/modules/test mod_bucketeer.c
Date Thu, 30 May 2002 21:43:05 GMT
> From: jerenkrantz@apache.org [mailto:jerenkrantz@apache.org]
> 
> jerenkrantz    02/05/30 14:10:19
> 
>   Modified:    modules/test mod_bucketeer.c
>   Log:
>   mod_bucketeer needs to preserve error buckets if it sees them rather
>   than silently discarding them.

This doesn't fix the underlying problem.  Mod_bucketeer needs to be
smart enough to copy buckets if it doesn't recognize their type.  If the
bucket can't be copied, then the filter should remove the bucket from
one brigade and add it to the other.

Any filter that silently removes buckets is broken.

Ryan


> 
>   Revision  Changes    Path
>   1.11      +8 -0      httpd-2.0/modules/test/mod_bucketeer.c
> 
>   Index: mod_bucketeer.c
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/modules/test/mod_bucketeer.c,v
>   retrieving revision 1.10
>   retrieving revision 1.11
>   diff -u -r1.10 -r1.11
>   --- mod_bucketeer.c	29 May 2002 06:19:26 -0000	1.10
>   +++ mod_bucketeer.c	30 May 2002 21:10:19 -0000	1.11
>   @@ -67,6 +67,7 @@
>    #include "util_filter.h"
>    #include "apr_buckets.h"
>    #include "http_request.h"
>   +#include "http_protocol.h"
> 
>    static const char bucketeerFilterName[] = "BUCKETEER";
>    module AP_MODULE_DECLARE_DATA bucketeer_module;
>   @@ -137,6 +138,13 @@
>                 * Ignore flush buckets for the moment..
>                 * we decide what to stream
>                 */
>   +            continue;
>   +        }
>   +
>   +        if (AP_BUCKET_IS_ERROR(e)) {
>   +            apr_bucket *err_copy;
>   +            apr_bucket_copy(e, &err_copy);
>   +            APR_BRIGADE_INSERT_TAIL(ctx->bb, err_copy);
>                continue;
>            }
> 
> 
> 
> 


Mime
View raw message