Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 64974 invoked by uid 500); 3 Apr 2002 17:32:23 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 64961 invoked from network); 3 Apr 2002 17:32:23 -0000 Date: Wed, 3 Apr 2002 12:32:14 -0500 (EST) From: Cliff Woolley X-X-Sender: root@deepthought.cs.virginia.edu To: dev@httpd.apache.org Subject: Re: fix t/ssl/http.t In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Wed, 3 Apr 2002, Doug MacEachern wrote: > > The correct solution is this: > cool, +1 Only one other thing I'm concerned about with it: It's only correct if we're in AP_MODE_GETLINE at the time of the error. Which we are in this case, but will it always be that way? Breakpoint 2, ssl_io_filter_Input (f=0x83b8728, bb=0x83b9f88, mode=AP_MODE_GETLINE, block=APR_BLOCK_READ, readbytes=0) at ssl_engine_io.c:813 813 return ssl_io_filter_error(f, bb, status); But any of AP_MODE_GETLINE, AP_MODE_READBYTES, or AP_MODE_SPECULATIVE could theoretically make it through to that point. Do we need to account for that and send the LF's in those other cases? And if so, should it be "\n\n" or "\r\n\r\n"? I need to trace through some more code. --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA