Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Errors-To: <wrowe@rowe-clan.net>
Message-Id: <5.1.0.14.2.20020405132856.02443830@pop3.rowe-clan.net>
Date: Fri, 05 Apr 2002 13:31:19 -0600
To: dev@httpd.apache.org
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: RE: I WANT A GA release
In-Reply-To: <scad88ab.092@prv-mail20.provo.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed

At 12:22 PM 4/5/2002, you wrote:
>I'm still seeing a problem with apr_tokenize_to_argv() that causes the
>parser to run off the end string.  I know this causes a fault on
>NetWare, but since I don't understand this code completely and the
>comments about allowing for a NULL argument are confusing, I was hoping
>someone would confirm or deny the problem.
>
>    It appears that apr_tokenize_to_argv() is running off the end of
>the string in the following while loop:

Brad,

   I believe you are correct.  Since win32 does tend to double-null terminate,
and we often have NULLed memory handy, this hasn't proven to be a problem.

   But I'd like to see good code as well as you... please feel free to fix.

   IIRC, we actually overallocate one of our apr_pstr fns for optimization
(to allow a single trailing character to be 'tacked on'.)  I imagine this has
helped mask this error.

Bill

Bill