httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject Re: [PATCH] init type mismatch in some minor scoreboard vars?
Date Fri, 05 Apr 2002 18:32:10 GMT
Aaron Bannert <aaron@clove.org> writes:

> Seems like the cast isn't necessary. There's also a potential
> size mismatch between conn_bytes's declared apr_off_t (which
> could be 64 bits). Is there any time that the zero wouldn't
> fill the LHS?
> 
> -aaron
> 
> Index: server/scoreboard.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/server/scoreboard.c,v
> retrieving revision 1.66
> diff -u -u -r1.66 scoreboard.c
> --- server/scoreboard.c	29 Mar 2002 14:33:50 -0000	1.66
> +++ server/scoreboard.c	4 Apr 2002 02:01:32 -0000
> @@ -432,8 +432,8 @@
>                  ws->my_access_count = 0L;
>                  ws->my_bytes_served = 0L;
>              }
> -            ws->conn_count = (unsigned short)0;
> -            ws->conn_bytes = (unsigned long)0;
> +            ws->conn_count = 0;
> +            ws->conn_bytes = 0;

+1

--
Jeff Trawick | trawick@attglobal.net
Born in Roswell... married an alien...

Mime
View raw message