httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul J. Reder" <rede...@remulak.net>
Subject Re: PR 7966
Date Fri, 12 Apr 2002 19:30:31 GMT
Um, mod_include *always* unsets the content length. What am I missing?

Ryan Bloom wrote:

>>From: Greg Marr [mailto:gregm@alum.wpi.edu]
>>
>>At 10:10 PM 04/11/2002, Ryan Bloom wrote:
>>
>>>>From: Justin Erenkrantz [mailto:jerenkrantz@apache.org]
>>>>On Thu, Apr 11, 2002 at 07:02:48PM -0700, Ryan Bloom wrote:
>>>>
>>>>>Dollars to Donuts, the problem is that the C-L filter isn't
>>>>>
>>>removing the
>>>
>>>>>C-L header from the request.  I won't have time to look at this
>>>>>
>>>for a
>>>
>>>>>few weeks though.
>>>>>
>>>>The request?  Don't you mean the file?
>>>>
>>>>Taking a quick look at default_handler:
>>>>
>>>>server/core.c line 3208:
>>>>ap_set_content_length(r, r->finfo.size);
>>>>
>>>>Isn't that call bogus?  Why just not let the C-L filter handle it?
>>>>
>>>No, it isn't bogus.  If the file isn't changed, then the call is
>>>correct.  It is only bogus if the content is changed, as it is with
>>>SSI requests.  If the C-L filter can't verify the C-L, it should be
>>>removing it from the request.  If it doesn't, that is the bug.
>>>
>>Isn't the filter that changes the content responsible for removing
>>the C-L?  Otherwise, the C-L filter would either remove the C-L every
>>time, or have to buffer the entire thing.
>>
> 
> There are people who believe that the filter that modifies the content
> should be responsible for removing the C-L (I happen to be one of them),
> but that is not the current design.
> 
> Ryan
> 
> 
> 
> 



-- 
Paul J. Reder
-----------------------------------------------------------
"The strength of the Constitution lies entirely in the determination of each
citizen to defend it.  Only if every single citizen feels duty bound to do
his share in this defense are the constitutional rights secure."
-- Albert Einstein



Mime
View raw message