httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: segfault in core_output_filter
Date Wed, 17 Apr 2002 21:20:59 GMT
On Wed, Apr 17, 2002 at 10:40:34AM -0700, Aaron Bannert wrote:
>...
> I don't think we should treat this as a special case at all. If an
> empty brigade happens to be passed down the filter chain, oh well. It
> shouldn't be fatal (as with an assert()), but it should be discouraged
> (punishable by wasted cpu cycles). Don't SEGV of course, but handle it
> just like any other brigade.
> 
> -0 to all three above proposals (ie. let's just fix the SEGV).

I totally agree with Aaron. An empty brigade is just zero-length content. A
total waste, but not inherently a problem.

Fix the SEGV. -1 on other solutions, especially ap_pass_brigade() changes
[which would impose overhead on *everybody*]

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message