httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: httpd-2.0/include ap_mmn.h
Date Tue, 16 Apr 2002 09:46:25 GMT
Woah... this just blew away all modules built for 2.0.35. This is an API
change, which thus means a very careful review of WHY this change was
required. Specifically, is there any way to avoid the change?

For example, we could introduce a new function, and call that one instead
from our code, leaving the old API untouched for third party modules.

IOW, please justify the necessity of bumping the MMN.

Cheers,
-g

On Sat, Apr 13, 2002 at 07:58:04PM -0000, wrowe@apache.org wrote:
> wrowe       02/04/13 12:58:04
> 
>   Modified:    .        CHANGES
>                include  ap_mmn.h
>   Log:
>     The fix requires a bump
>   
>   Revision  Changes    Path
>   1.704     +5 -0      httpd-2.0/CHANGES
>   
>   Index: CHANGES
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/CHANGES,v
>   retrieving revision 1.703
>   retrieving revision 1.704
>   diff -u -r1.703 -r1.704
>   --- CHANGES	12 Apr 2002 19:58:51 -0000	1.703
>   +++ CHANGES	13 Apr 2002 19:58:04 -0000	1.704
>   @@ -1,5 +1,10 @@
>    Changes with Apache 2.0.36
>    
>   +  *) Allow Win32 shebang scripts to follow the path (or omit the .exe
>   +     suffix from the shebang command), and allow ScriptInterpreterSource
>   +     Registry or RegistryStrict to override shebang lines, as 1.3 did.
>   +     [William Rowe]
>   +
>      *) worker MPM: Fix a situation where a child exited without releasing
>         the accept mutex.  Depending on the OS and mutex mechanism this 
>         could result in a hang.  [Jeff Trawick]
>   
>   
>   
>   1.42      +2 -1      httpd-2.0/include/ap_mmn.h
>   
>   Index: ap_mmn.h
>   ===================================================================
>   RCS file: /home/cvs/httpd-2.0/include/ap_mmn.h,v
>   retrieving revision 1.41
>   retrieving revision 1.42
>   diff -u -r1.41 -r1.42
>   --- ap_mmn.h	29 Mar 2002 08:17:19 -0000	1.41
>   +++ ap_mmn.h	13 Apr 2002 19:58:04 -0000	1.42
>   @@ -103,12 +103,13 @@
>     * 20020319 (2.0.34-dev) M_INVALID changed, plus new M_* methods for RFC 3253
>     * 20020327 (2.0.35-dev) Add parameter to quick_handler hook
>     * 20020329 (2.0.35-dev) bump for addition of freelists to bucket API
>   + * 20020413 (2.0.36-dev) bump for new arg to opt fn ap_cgi_build_command
>     */
>    
>    #define MODULE_MAGIC_COOKIE 0x41503230UL /* "AP20" */
>    
>    #ifndef MODULE_MAGIC_NUMBER_MAJOR
>   -#define MODULE_MAGIC_NUMBER_MAJOR 20020329
>   +#define MODULE_MAGIC_NUMBER_MAJOR 20020413
>    #endif
>    #define MODULE_MAGIC_NUMBER_MINOR 0                     /* 0...n */
>    #define MODULE_MAGIC_NUMBER MODULE_MAGIC_NUMBER_MAJOR	/* backward compat */
>   
>   
>   

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message