httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: [PATCH] Move 100-Continue into HTTP_IN
Date Sat, 13 Apr 2002 02:43:50 GMT
On Fri, Apr 12, 2002 at 05:01:38PM -0700, Justin Erenkrantz wrote:
> As Ryan has pointed out, ap_http_filter doesn't properly
> handle 100-Continue requests.  Rather than call
> ap_should_client_block, HTTP_IN (aka ap_http_filter) should
> handle this transparently (since I am in the camp that
> HTTP_IN should handle all HTTP protocol issues).
> 
> Untested.  Can I get any concept +1s (or -1s)?  -- justin

+1 on concept. But I'll defer to Roy's review of the patch itself.

When the application first attempts to read *body* content from the input
filter stack, the HTTP_IN should generate the 100-Continue, if appropriate.
Doing it there will enable it to work for both filter-based modules and the
old-style API.

It's a little tweaky for an input module to generate output, but we already
do that in the SSL module, so we've definitely seen that before.

Note that HTTP_IN can even discard the body in case of an error.

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message