httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <>
Subject Re: [PATCH] fix LimitRequestBody for all input handlers
Date Thu, 11 Apr 2002 23:37:39 GMT
On Thu, Apr 11, 2002 at 04:34:08PM -0700, Aaron Bannert wrote:
> I guess I'm unclear why it is CGI's responsibility to watch for this.
> Do we then need to put these kinds of checks in every http-body-using
> element? (My relative newness to the filters is showing.)

What happens in CGI if it gets APR_EGENERAL from ap_http_filter()?
(I honestly don't know...)  This is what ap_http_filter() should be
returning once the limit is reached.

> Another thing I'm even less clear about is what ap_get_client_block is
> for. Where the heck do normal modules grab the entire post body from
> (I truly don't know)?

At this point, I don't believe anything.  They should just be
using ap_get_brigade() - as ap_http_filter (HTTP_IN) does all of
the dechunking seemlessly.  -- justin

View raw message