httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject Re: Question about this patch to core_input_filter...
Date Sat, 06 Apr 2002 18:14:54 GMT

> Justin,
> This is your patch... core_input_filter adds a socket bucket, does a
APR_BRIGADE_NORMALIZE
> and then calls APR_BRIGADE_EMPTY(). How can this check ever return an empty brigade?
> Bill
>
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/server/core.c,v
> retrieving revision 1.144
> retrieving revision 1.145
> diff -u -r1.144 -r1.145
> --- httpd-2.0/server/core.c 2002/02/05 22:56:44 1.144
> +++ httpd-2.0/server/core.c 2002/02/06 02:24:18 1.145
> @@ -3062,9 +3062,13 @@
>      /* ### This is bad. */
>      APR_BRIGADE_NORMALIZE(ctx->b);
>
> -    /* check for empty brigade *AFTER* APR_BRIGADE_NORMALIZE() */
> +    /* check for empty brigade *AFTER* APR_BRIGADE_NORMALIZE()
> +     * If we have lost our socket bucket (see above), we are EOF.

Let me ask a different way... Referring to the comment above, how can we loose a socket
bucket that was just created?

Thanks,
Bill


Mime
View raw message