Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Errors-To: <wrowe@rowe-clan.net>
Message-Id: <5.1.0.14.2.20020320002814.00b1e6e0@pop3.rowe-clan.net>
Date: Wed, 20 Mar 2002 00:30:31 -0600
To: dev@httpd.apache.org
From: "William A. Rowe, Jr." <wrowe@rowe-clan.net>
Subject: Re: cvs commit: httpd-2.0/server/mpm/winnt mpm_winnt.c
In-Reply-To: <Pine.LNX.4.21.0203200030440.31730-100000@shell.ntrnet.net>
References: <20020320042955.22386.qmail@icarus.apache.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format=flowed

At 11:31 PM 3/19/2002, you wrote:
>On 20 Mar 2002 wrowe@apache.org wrote:
>
> >   +    if (!restart && ((parent_pid == my_pid) || one_process)) {
> >            /* Set up the scoreboard. */
> >            if (ap_run_pre_mpm(pconf, SB_SHARED) != OK) {
> >                return 1;
>
>While I agree with this patch, you also need to kill the cleanup on the
>scoreboard, so that it isn't set to NULL when pconf is cleared.

No you do not kill the cleanup - you rescope it.  See the next patch.
Really, lovely, let's off and leave a dangling object that fell out of scope
with no cleanup.  pre_mpm requires a process->pool.

>And, you
>need to find some way to pass the scoreboard back to the child process
>because you are about to start a new one.

What are you talking about, we killed Kenny :0/  This next generation we
have new offspring.