Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Date: Tue, 19 Mar 2002 10:13:44 -0800
From: Justin Erenkrantz <jerenkrantz@apache.org>
To: dev@httpd.apache.org
Subject: Re: [PATCH] AddOutputFiltersbyType (revised)
Message-ID: <20020319101344.B5387@apache.org>
Mail-Followup-To: Justin Erenkrantz <jerenkrantz@apache.org>,
	dev@httpd.apache.org
References: <001301c1cc48$58bf05b0$c900000a@KOJ>
 <000801c1ce36$ee9802e0$6701a8c0@sashimi>
 <01bd01c1cf71$45eb09d0$68261b09@sashimi>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <01bd01c1cf71$45eb09d0$68261b09@sashimi>;
 from bill@wstoddard.com on Tue, Mar 19, 2002 at 01:09:49PM -0500

On Tue, Mar 19, 2002 at 01:09:49PM -0500, Bill Stoddard wrote:
> Any votes on this patch (even in concept if not on all the details)? If it looks like what
> we want to do, I'll polish it up and commit it.

+1 (concept).

ap_set_content_type seems a better name though.

My only implementation concern will be whether we ensure that we get
the ordering right when inserting filters.  (We can't just blindly
insert them after the current filter - say we want to add an
AP_FTYPE_CONTENT_SET filter - it has to be inserted after.)

The docco should state that only AP_FTYPE_RESOURCE filters (or hooks
run before filters) can change the content-type.  -- justin