Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Reply-To: <rbb@covalent.net>
From: "Ryan Bloom" <rbb@covalent.net>
To: <dev@httpd.apache.org>,
	<httpd-2.0-cvs@apache.org>
Subject: RE: cvs commit: httpd-2.0/modules/http http_core.c http_protocol.c
Date: Sun, 3 Mar 2002 21:55:25 -0800
Organization: Covalent Technologies
Message-ID: <000401c1c341$2dfefa20$0a01230a@KOJ>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="US-ASCII"
Content-Transfer-Encoding: 7bit
In-Reply-To: <20020304055445.71972.qmail@icarus.apache.org>
Importance: Normal

>   Modified:    modules/http http_core.c http_protocol.c
>   Log:
>   Adding the same filters over and over again used to be okay, because
>   we would lose the extra filters.  Now, if a filter is added, it is
run.
>   Unfortunately, this can cause an infinite loop, or it can cause
request
>   headers to appear twice.  This commit removes two instances in the
core
>   where we were inserting filters for a second and third time.  The
bug
>   was that error responses were causing infinite loops.
> 
>   This also removes the reset_filters function, which did the exact
>   same thing as add_required_filters.  The two functions were both
called
>   in error conditions, which was part of what caused this bug.

Justin,

This fixes the second of your two bugs.  Thanks for finding those, I'm
sorry I let them slip through.  BTW, the number of bugs that this code
exposed has convinced me that this is the correct direction to go.  The
reason I say that is that all of the bugs that have been exposed are
happening because we tried to hack around problems with the filters.

Ryan