httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joshua Slive <jos...@slive.ca>
Subject Re: [PATCH] default_handler and no directory_walk
Date Fri, 22 Mar 2002 19:58:23 GMT

On Fri, 22 Mar 2002, Bill Stoddard wrote:

> Here is a patch to error out if the default handler is entered w/o directory walk being
> done. I believe strongly that we should not attempt to recover from this error (ie
> "back-up and try directory walk"). This failure means that a module is defective and
that
> module should be fixed.

> +    if (!req_cfg->directory_walked) {
> +        ap_log_rerror(APLOG_MARK, APLOG_ERR|APLOG_NOERRNO, 0, r,
> +                      "directory_walk was not performed for file: %s",
> +                      apr_pstrcat(r->pool, r->filename, r->path_info, NULL));
> +        return HTTP_NOT_FOUND;
> +    }
> +

More comments from the peanut gallery: If this request is being refused
because of a broken module, shouldn't that be 500 Internal Server Error
rather than 404 File Not Found?

Joshua.


Mime
View raw message