httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sander Striker" <stri...@apache.org>
Subject Torching ap_document_root, WAS: RE: Code questions
Date Thu, 07 Mar 2002 20:13:27 GMT
> From: Sander Striker [mailto:striker@apache.org]
> Sent: 07 March 2002 20:48

>>> server/core.c:661
>>>     AP_DECLARE(const char *) ap_document_root(request_rec *r) /* Don't use this!
*/
>>> 
>>> If we shouldn't use it, why is it still here?
>> 
>> Because people are lazy and most people didn't realize that comment
>> existed.  If nobody is using that function, remove it.
> 
> Okay, thanks for the heads up.

modules/ssl/ssl_engine_vars.c:158:            result = (char *)ap_document_root(r);
modules/mappers/mod_rewrite.c:1255:                if ((ccp = ap_document_root(r)) != NULL)
{
modules/mappers/mod_rewrite.c:1552:                if ((ccp = ap_document_root(r)) != NULL)
{
modules/mappers/mod_rewrite.c:3492:        result = ap_document_root(r);
server/util_script.c:278:    apr_table_addn(e, "DOCUMENT_ROOT", ap_document_root(r));   /*
Apache */

Ofcourse there are always places where such a function is used...
Question is now, are they legit?  Should they be changed?

Sander


Mime
View raw message