httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <madhusudan_mathiha...@hp.com>
Subject RE: [PATCH] SSL Session Caching stuff
Date Fri, 15 Mar 2002 01:05:41 GMT
'just realized that a stray log message was left over in my patch :

-Madhu

Index: ssl_scache_shmht.c
===================================================================
RCS file: /home/cvspublic/httpd-2.0/modules/ssl/ssl_scache_shmht.c,v
retrieving revision 1.6
diff -u -r1.6 ssl_scache_shmht.c
--- ssl_scache_shmht.c  14 Mar 2002 23:31:23 -0000      1.6
+++ ssl_scache_shmht.c  15 Mar 2002 01:02:00 -0000
@@ -78,10 +78,6 @@
     SSLModConfigRec *mc = myModConfig((server_rec *)opt_param);
 
     apr_rmm_off_t off = apr_rmm_calloc(mc->pSessionCacheDataRMM,
(number*size));
-ssl_log((server_rec *)opt_param, SSL_LOG_ERROR,
-    "rmm calloc returning %ld %ld size %d",
-    off, apr_rmm_addr_get(mc->pSessionCacheDataRMM, off), (number * size));
-
     return apr_rmm_addr_get(mc->pSessionCacheDataRMM, off);
 }
 



-----Original Message-----
From: Doug MacEachern [mailto:dougm@covalent.net]
Sent: Thursday, March 14, 2002 4:45 PM
To: 'dev@httpd.apache.org'
Subject: RE: [PATCH] SSL Session Caching stuff


On Thu, 14 Mar 2002, MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote:

> if (Pass-1) {
...
> }
> else if (Pass-2) {

i don't know how to fix it, but we should't assume anything based pass-1, 
pass-2, etc.  otherwise it isn't possible to add mod_ssl to a server that 
was started without it, consider:

1) apachectl start (no mod_ssl in httpd.conf)

2) add mod_ssl to httpd.conf and configure SSLSharedCache

3) apachectl graceful

the session cache will never be initialized.

and consider re-configuring the session cache parameters and then doing a 
graceful restart.  ok if it's just a temporary workaround though.

Mime
View raw message