httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1)" <madhusudan_mathiha...@hp.com>
Subject RE: [PATCH] SSL Session Caching stuff
Date Fri, 15 Mar 2002 00:06:27 GMT
Thanks for the commit.

As regards the specific portion from ssl_scache.c, that is where I'm
confused as to how apr_shm_* works. I was trying to get the logic something
like :

if (Pass-1) {
  Create the shared memory - apr_shm_init(..)
  Initialize RMM - apr_rmm_init(..)
}
else if (Pass-2) {
  Attach to the shared memory - apr_shm_attach(..)
  Attach to the RMM - apr_rmm_attach(..)
}

but the above logic never worked. So, inorder to get the logic working, I'd
to force the creation of the shared memory in Pass-2 - which is NOT what we
want to do. That's the reason I was hoping if somebody could review the
apr_shm_* portion and let me know what might be wrong.

Thanks
-Madhu

-----Original Message-----
From: Doug MacEachern [mailto:dougm@covalent.net]
Sent: Thursday, March 14, 2002 3:37 PM
To: 'dev@httpd.apache.org'
Subject: Re: [PATCH] SSL Session Caching stuff


looks good to me madhu.  haven't tested, but it compiles, so i've 
committed the patch and remaining issues can be worked out later.
only have one question at the moment, what is this for?

+        void *data;
+        const char *userdata_key = "ssl_scache_init";
+
+        apr_pool_userdata_get(&data, userdata_key, s->process->pool);
+        if (!data) {
+            apr_pool_userdata_setn((const void *)1, userdata_key,
+                                   apr_pool_cleanup_null,
s->process->pool);
+            return;
+        }

Mime
View raw message