httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: 1.3.24-dev new warning...
Date Fri, 19 Apr 2002 18:07:13 GMT
At 10:03 AM 3/19/2002, you wrote:
>At 10:42 PM -0600 3/7/02, William A. Rowe, Jr. wrote:
> >C:\clean\apache-1.3\src\modules\proxy\proxy_util.c(565)
> >  : warning C4018: '<' : signed/unsigned mismatch
> >
> >            n = ap_bread(f, buf, MIN(buf_size, len - total_bytes_rcvd));
>
>I had posted a patch regarding this a bit ago... Any feedback? I was
>not able to recreate the exact error messages locally on any of
>my machines, so I couldn't see if it solved the specific problem
>(without creating more :) ).

Doh!  MIN() is implemented in terms of a terniary, and those are very
broken in terms of the result type on win32.  Casting the MIN() back to
the arg type of ap_bread() should be sufficient.



Mime
View raw message