httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "William A. Rowe, Jr." <wr...@rowe-clan.net>
Subject Re: cvs commit: httpd-2.0/server/mpm/winnt mpm_winnt.c
Date Wed, 20 Mar 2002 06:30:31 GMT
At 11:31 PM 3/19/2002, you wrote:
>On 20 Mar 2002 wrowe@apache.org wrote:
>
> >   +    if (!restart && ((parent_pid == my_pid) || one_process)) {
> >            /* Set up the scoreboard. */
> >            if (ap_run_pre_mpm(pconf, SB_SHARED) != OK) {
> >                return 1;
>
>While I agree with this patch, you also need to kill the cleanup on the
>scoreboard, so that it isn't set to NULL when pconf is cleared.

No you do not kill the cleanup - you rescope it.  See the next patch.
Really, lovely, let's off and leave a dangling object that fell out of scope
with no cleanup.  pre_mpm requires a process->pool.

>And, you
>need to find some way to pass the scoreboard back to the child process
>because you are about to start a new one.

What are you talking about, we killed Kenny :0/  This next generation we
have new offspring.



Mime
View raw message