httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Pane <brian.p...@cnet.com>
Subject Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c mod_cgid.c
Date Sun, 31 Mar 2002 05:14:41 GMT
Brian Havard wrote:

>On Sat, 30 Mar 2002 16:14:55 +0000, Thom May wrote:
>
>>This change appears to have broken some cgÑ  scripts - cricket
>><http://cricket.sourceforge.net/> worked fine in 2.0.33 but in 2.0.34 and
>>35-dev:
>>
>>[Sat Mar 30 15:20:03 2002] [error] [client 192.168.0.34] malformed header
>>
>>from 
>: /usr/lib/cgi-bin/cricket/grapher.cgi
>
>I'm seeing something similar to this in recent code. This is from a virtual
>include in an SSI:
>
>[Sun Mar 31 14:24:05 2002] [error] [client 202.12.87.82] malformed header
>from script. Bad header=
>: F:/Data/Web.Pages/Silk/cgi-bin/count, referer: http://kheldar/silk/
>
>Looking at the log file in a hex view the bad header appears to be a single
>CR character, suggesting that CR/LF terminated lines are no longer accepted
>from CGI scripts.
>

Yes, that's the problem.  I based getsfunc_BRIGADE() on the
semantics of the apr_file_gets() call that it replaced--but
the Unix version, which only checks for LF and not CR.  Your
patch looks good.

Thanks,
--Brian



Mime
View raw message