httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-1.3/src/main http_protocol.c
Date Tue, 26 Mar 2002 23:12:08 GMT
On Thu, Mar 21, 2002 at 02:49:47PM -0000, minfrin@apache.org wrote:
>...
>   +++ http_protocol.c	21 Mar 2002 14:49:46 -0000	1.312
>...
>   +    /* keep a previously set server header (possible from proxy), otherwise
>   +     * generate a new server header */
>   +    if (server = ap_table_get(r->headers_out, "Server")) {

To avoid warnings on some compilers, this assignment should have extra stuff
around it to prevent a warning about possible typo'ing of "==". For example:

  if ((server = ap_table_get(r->headers_out, "Server")) != NULL) {


Just a standard rule to apply for any construct like this you do...

Cheers,
-g

-- 
Greg Stein, http://www.lyra.org/

Mime
View raw message