httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Justin Erenkrantz <jerenkra...@apache.org>
Subject Re: [PATCH] AddOutputFiltersbyType (revised)
Date Tue, 19 Mar 2002 18:13:44 GMT
On Tue, Mar 19, 2002 at 01:09:49PM -0500, Bill Stoddard wrote:
> Any votes on this patch (even in concept if not on all the details)? If it looks like
what
> we want to do, I'll polish it up and commit it.

+1 (concept).

ap_set_content_type seems a better name though.

My only implementation concern will be whether we ensure that we get
the ordering right when inserting filters.  (We can't just blindly
insert them after the current filter - say we want to add an
AP_FTYPE_CONTENT_SET filter - it has to be inserted after.)

The docco should state that only AP_FTYPE_RESOURCE filters (or hooks
run before filters) can change the content-type.  -- justin

Mime
View raw message