httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <b...@wstoddard.com>
Subject [PATCH] Do not run fixups against dirent subrequests
Date Wed, 13 Mar 2002 21:41:00 GMT
I really don't like this patch because it stinks of creeping hacks built upon hacks but it
should suffice to get a discussion going.

This patch fixes a bug where a directory index of c:/website causes subrequests to be
generated searching for index.html and index.html.var files under subdirs in c:/website.
(and the bug totally hoses up directory indexing when mod_cache is enabled).

Thoughts?

Bill

Index: request.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/request.c,v
retrieving revision 1.105
diff -u -r1.105 request.c
--- request.c 13 Mar 2002 19:41:56 -0000 1.105
+++ request.c 13 Mar 2002 21:33:39 -0000
@@ -302,8 +302,11 @@
         return decl_die(access_status, "find types", r);
     }

-    if ((access_status = ap_run_fixups(r)) != 0) {
-        return access_status;
+    /* Don't run fixups on a dirent subrequest */
+    if (!file_req && !r->finfo.filetype) {
+        if ((access_status = ap_run_fixups(r)) != 0) {
+            return access_status;
+        }
     }

     return OK;


Mime
View raw message