httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bill Stoddard" <>
Subject Re: [PATCH] AddOutputFiltersbyType
Date Fri, 15 Mar 2002 17:19:07 GMT

> > The essential feature of this patch is that
> > ap_add_output_filters_by_type() is called out
> > of the ap_http_header_filter.
> You can't solve this problem this way.  The problem here, is that the
> first time down the filter stack, the data won't go through the correct
> filters.  Think of what would happen if you had CGI script that output
> text/html, and you had
> AddOutputFiltersByType INCLUDES text/html.
> With this patch, it would be possible to miss SSI tags in the first
> chunk of data.
Not sure I understand why this is the case.  The call to ap_add_output_filters_by_type()
is being called right before the call to insert the chunked encoding filter. If what you
say is true, then wouldn't the problem exist with the chunked encoding filter as well?

> The only way to do this, is to have a filter at the end of the RESOURCE
> and CONTENT_SET filter stacks.  That filter would add more filters, and
> then move itself to below those new filters to check if the content-type
> has changed.

Yep, I considered this and will implement it if this is what we really need to do.

> Ryan


View raw message