httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <...@covalent.net>
Subject RE: Do graceful restarts actually work anywhere?
Date Tue, 19 Mar 2002 01:17:11 GMT
> "Ryan Bloom" <rbb@covalent.net> writes:
> 
> > Just looking through the code and graceful restarts really shouldn't
be
> > working right now.  The problem is that we pass pconf into the
pre_mpm
> > phase, but on Unix we only call the pre_mpm phase on graceless
shutdown
> > or when the server first starts.  We clear the pconf pool on every
> > restart, and we register a cleanup with pconf to destroy the
scoreboard.
> >
> > If I have traced the code correctly, this means that we should be
> > deleting the scoreboard on every graceful restart and not
re-creating
> > it.  I can't see how this is not causing severe seg faults.
> 
> Perhaps you missed this line?
> 
>   apr_pool_cleanup_kill(pconf, NULL, ap_cleanup_scoreboard);
> 
> Graceful restarts for prefork are working properly as far as I can
> tell.
> 
> Graceful restarts for worker have at least the following problem:

YES!  I missed that line.  Why don't we just pass pglobal to the pre_mpm
phase.

Ryan



Mime
View raw message