httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Bloom" <>
Subject RE: [PATCH] invalid HTTP status codes in access log
Date Fri, 22 Mar 2002 22:38:22 GMT
> > I am more than happy with that argument.  I will change the second
> > return to APR_SUCCESS, and commit.
> One thing I'm confused about... core_output_filter's return type is
> apr_status_t.  HTTP_INTERNAL_SERVER_ERROR is not an apr_status_t.  It
> seems to me that core_output_filter should keep returning rv and the
> caller should look for a filter return code != APR_SUCCESS and
> that into HTTP_INTERNAL_SERVER_ERROR at that time.

Filters shouldn't return apr_status_t's, because there is nothing that
the core can do with a status code.  The filter must be responsible for
converting the error code to an HTTP status code.  The reason that the
filters must return the HTTP status code, is that handlers return the
status code, and 99% of the time, handlers call ap_pass_brigade, and
return the result.


View raw message