Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Sender: trawick@rdu163-40-092.nc.rr.com
To: dev@httpd.apache.org
Subject: Re: cvs commit: httpd-2.0/server core.c
References: <20020205225644.45157.qmail@icarus.apache.org>
	<20020205225825.GG28973@ebuilt.com>
From: Jeff Trawick <trawick@attglobal.net>
Date: 05 Feb 2002 18:00:14 -0500
In-Reply-To: <20020205225825.GG28973@ebuilt.com>
Message-ID: <m38za7edq9.fsf@rdu163-40-092.nc.rr.com>
Lines: 24
User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/20.7
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Justin Erenkrantz <jerenkrantz@ebuilt.com> writes:

> On Tue, Feb 05, 2002 at 10:56:44PM -0000, trawick@apache.org wrote:
> > trawick     02/02/05 14:56:44
> > 
> >   Modified:    .        CHANGES
> >                server   core.c
> >   Log:
> >   In core_input_filter, check for an empty brigade after
> >   APR_BRIGADE_NORMALIZE().  Otherwise, we can get segfaults if a
> >   client says it will post some data but we get FIN before any
> >   data arrives.
> 
> Ah, yes.  That looks right.  Do we think this fixes the
> daedalus cores?  -- justin

I'm quite sure it fixes the prevalent scenario.  Greg mentioned
another segfault flavor on the input side.  I haven't looked at that
one to see what it is about.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...