Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 80898 invoked by uid 500); 28 Feb 2002 23:25:17 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 80870 invoked from network); 28 Feb 2002 23:25:16 -0000 Date: Thu, 28 Feb 2002 18:25:05 -0500 (EST) From: Cliff Woolley X-X-Sender: root@deepthought.cs.virginia.edu To: Brian Pane cc: dev@httpd.apache.org, Subject: Re: cvs commit: httpd-2.0/modules/filters mod_include.c In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Thu, 28 Feb 2002, Cliff Woolley wrote: > On Thu, 28 Feb 2002, Greg Stein wrote: > > > > /* prepend ctx->ssi_tag_brigade onto bb */ > > > APR_BRIGADE_CONCAT(ctx->ssi_tag_brigade, bb); > > > APR_BRIGADE_CONCAT(bb, ctx->ssi_tag_brigade); > > > > That is *very* obtuse. I can't imagine anybody figuring out that idiom > > means "prepend". Yes, please add an appropriate macro. > > Okay, will add. Committed. Brian, can you please run your tests on it for me? I've yet to find the exact test case to get into that block of code. --Cliff -------------------------------------------------------------- Cliff Woolley cliffwoolley@yahoo.com Charlottesville, VA