Return-Path: Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 16799 invoked by uid 500); 4 Feb 2002 13:08:55 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: list-post: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 16786 invoked from network); 4 Feb 2002 13:08:55 -0000 Date: Mon, 4 Feb 2002 14:08:54 +0100 From: Martin Kraemer To: dev@httpd.apache.org Subject: Re: [PATCH] SSL_* in suexec safe env list Message-ID: <20020204140854.D72000@deejai2.mch.fsc.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from joshua@slive.ca on Sun, Feb 03, 2002 at 12:37:58PM -0500 X-Operating-System: FreeBSD 4.5-STABLE FreeBSD 4.5-STABLE X-Organization: Fujitsu Siemens Computers (Muenchen, Germany) X-Disclaimer: THE COMMENTS CONTAINED IN THIS MESSAGE REFLECT THE VIEWS OF THE WRITER AND ARE NOT NECESSARILY THE VIEWS OF FUJITSU-SIEMENS COMPUTERS X-No-Junk-Mail: I do not want to get *any* junk mail. X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N On Sun, Feb 03, 2002 at 12:37:58PM -0500, Joshua Slive wrote: > > > From: Zvi Har'El [mailto:rl@math.technion.ac.il] > > > triple rather then > > double strncmp: > > > > - if (!strncmp(*ep, "HTTP_", 5)) { > > + if (!strncmp(*ep, "HTTP_", 5) || !strncmp(*ep, "HTTPS", 5) || (no, not like that. not strncmp, but strcmp(*ep, "HTTPS") > > + !strncmp(*ep, "SSL_", 4)) { > > As I said, I'm not going to commit without two "+1"s. > > > Index: suexec.c > =================================================================== > RCS file: /home/cvs/httpd-2.0/support/suexec.c,v > retrieving revision 1.17 > diff -u -d -b -r1.17 suexec.c > --- suexec.c 22 Nov 2001 07:42:13 -0000 1.17 > +++ suexec.c 3 Feb 2002 17:30:13 -0000 > @@ -136,6 +136,7 @@ > "DOCUMENT_URI", > "FILEPATH_INFO", > "GATEWAY_INTERFACE", > + "HTTPS", > "LAST_MODIFIED", > "PATH_INFO", > "PATH_TRANSLATED", Yep, that's cleaner. +1. Martin -- | Fujitsu Siemens Fon: +49-89-636-46021, FAX: +49-89-636-47655 | 81730 Munich, Germany