httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@attglobal.net>
Subject [PATCH] Re: httpd.core.3 (2nd flavor seen on current code)
Date Wed, 06 Feb 2002 01:01:49 GMT
This is it for me today...

Perhaps the patch will show somebody (Justin?) what happened with
httpd.core.3.

Index: server/protocol.c
===================================================================
RCS file: /home/cvs/httpd-2.0/server/protocol.c,v
retrieving revision 1.77
diff -u -r1.77 protocol.c
--- server/protocol.c	30 Jan 2002 04:37:29 -0000	1.77
+++ server/protocol.c	6 Feb 2002 00:58:39 -0000
@@ -401,6 +401,11 @@
             return rv;
         }
 
+        if (APR_BRIGADE_EMPTY(bb)) {
+            apr_brigade_destroy(bb);
+            goto done;
+        }
+        
         e = APR_BRIGADE_FIRST(bb);
 
         /* If we see an EOS, don't bother doing anything more. */
@@ -477,6 +482,8 @@
         }
     }
 
+ done:
+    
     /* FIXME: Can we optimize this at all by placing it a different layer? */
     ap_xlate_proto_from_ascii(*s, bytes_handled);
     *read = bytes_handled;

Note that after the "fix" I ended up with this in the error log:

[Tue Feb 05 19:59:09 2002] [error] [client 127.0.0.1] (20514)End of
file found: get_mime_headers() failed
[Tue Feb 05 19:59:09 2002] [error] [client 127.0.0.1] client sent
HTTP/1.1 request without hostname (see RFC2616 section 14.23): /cocoon/developing/graphics/Using%20Databases-label_over.jpg

Perhaps the wrong log priority is used here?

Y'all have fun...  Commit something so I don't get too anxious to turn
my +1 in STATUS upside down.

-- 
Jeff Trawick | trawick@attglobal.net | PGP public key at web site:
       http://www.geocities.com/SiliconValley/Park/9289/
             Born in Roswell... married an alien...

Mime
View raw message