httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Cliff Woolley <jwool...@virginia.edu>
Subject Re: cvs commit: httpd-2.0/modules/filters mod_include.c
Date Wed, 27 Feb 2002 23:58:29 GMT
On 24 Feb 2002 brianp@apache.org wrote:

>   +            if (!APR_BRIGADE_EMPTY(ctx->ssi_tag_brigade)) {
>   +                for (;;) {
>   +                    apr_bucket *e = APR_BRIGADE_LAST(ctx->ssi_tag_brigade);
>   +                    if (e == APR_BRIGADE_SENTINEL(ctx->ssi_tag_brigade)) {
>   +                        break;
>   +                    }
>   +                    APR_BUCKET_REMOVE(e);
>   +                    APR_BRIGADE_INSERT_HEAD(bb, e);
>   +                }
>                }

<sigh>

PLEASE use APR_BRIGADE_CONCAT() for these kinds of things.  I can't say
that frequently enough I guess.

--Cliff


--------------------------------------------------------------
   Cliff Woolley
   cliffwoolley@yahoo.com
   Charlottesville, VA



Mime
View raw message