httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <i...@apache.org>
Subject Re: [PATCH] mod_deflate
Date Fri, 15 Feb 2002 19:29:55 GMT
Sander Striker wrote:
>>From: Ian Holsman [mailto:ianh@apache.org]
>>Sent: 15 February 2002 18:44
>>
>  
> Hi,
> 
> 
>>I'm still not very happy about compressing EVERYTHING and excluding
>>certain browsers as you would have to exclude IE & Netscape.
>>
>>so this is a -1 for this patch.
>>in order to change this checks need to be there with a directive to
>>ignore them (default:off)
>>
> 
> Hopefully this patch resolves your veto.  Without that patch, deflate
> would be useless for subversion (and any other client that can
> handle compressed responses other than text/html).

veto resolved.
go apply it.

> 
> 
> Sander
> 
> 
> Index: modules/experimental/mod_deflate.c
> ===================================================================
> RCS file: /home/cvspublic/httpd-2.0/modules/experimental/mod_deflate.c,v
> retrieving revision 1.3
> diff -u -r1.3 mod_deflate.c
> --- modules/experimental/mod_deflate.c  15 Feb 2002 16:33:33 -0000      1.3
> +++ modules/experimental/mod_deflate.c  15 Feb 2002 17:50:56 -0000
> @@ -235,6 +235,15 @@
>              return ap_pass_brigade(f->next, bb);
>          }
> 
> +        /* Some browsers might have problems with content types
> +         * other than text/html, so set gzip-only-text/html
> +         * (with browsermatch) for them
> +         */
> +        if (strncmp(r->content_type, "text/html", 9)
> +            && apr_table_get(r->subprocess_env, "gzip-only-text/html")) {
> +            return ap_pass_brigade(f->next, bb);
> +        }
> +
>          /* some browsers might have problems, so set no-gzip
>           * (with browsermatch) for them */
>          if (apr_table_get(r->subprocess_env, "no-gzip")) {
> 
> 




Mime
View raw message