httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Holsman <i...@apache.org>
Subject Re: [PATCH] mod_deflate
Date Fri, 15 Feb 2002 17:44:19 GMT


I'm still not very happy about compressing EVERYTHING and excluding
certain browsers
as you would have to exclude IE & Netscape.

so
this is a
-1 for this patch.
in order to change this checks need to be there with a directive to
ignore them (default:off)




Sander Striker wrote:
>>Sander Striker wrote:
>>
>>
>>>@@ -297,6 +287,7 @@
>>>
>>>         apr_table_setn(r->headers_out, "Content-Encoding", "gzip");
>>>         apr_table_setn(r->headers_out, "Vary", "Accept-Encoding");
>>>+        apr_table_unset(r->headers_out, "Content-Length");
>>>     }
>>>
>>>     APR_BRIGADE_FOREACH(e, bb) {
>>>
>>>  
>>>
>>Do you mean that till now, mod_deflate preserved the original CL, of
>>the file before being deflated ???
>>
> 
> yes
> 
> 
>>Wow...
>>Maybe I am confused, or miss something, but how has mod_deflate
>>succeeded to work till now?
>>Or are gzip-supporting-browsers smart enough to ignore the CL of
>>compressed responses?
>>
> 
> Apparently so*.  It is in modules/experimental for a reason, although
> I'm sure we'd all love to get it out.  It will require some work though.
> 
> *) Or we were just lucky.  Subversion only failed a long way into
> the process of checking out a source tree.  It had pulled down
> quite an amount of files prior to failing (due to the server
> closing the connection I might add).
> 
> 
>>Eli Marmor
>>
> 
> Sander
> 
> 
> 




Mime
View raw message