httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Aaron Bannert <aa...@clove.org>
Subject Re: cvs commit: httpd-2.0/modules/mappers mod_rewrite.c
Date Sun, 17 Feb 2002 20:42:16 GMT
On Sat, Feb 16, 2002 at 09:57:17PM -0000, brianp@apache.org wrote:
> brianp      02/02/16 13:57:17
> 
>   Modified:    modules/mappers mod_rewrite.c
>   Log:
>   Converted the rewrite mapper lock to the new lock API

Did mod_rewrite actually need a LOCKALL? If so, apr_proc_mutex_t
is an insufficient replacement, since it can not guarantee mutual
exclusion of threads in the same process.

-aaron

>   -    rc = apr_lock_create(&rewrite_mapr_lock_acquire, APR_MUTEX, APR_LOCKALL, 
>   -                         APR_LOCK_DEFAULT, lockname, p);
>   +    rc = apr_proc_mutex_create(&rewrite_mapr_lock_acquire, lockname,
>   +                               APR_LOCK_DEFAULT, p);

Mime
View raw message